feat(amazonq): enable pre flare experiment #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will-ShaoHua
approved these changes
Sep 9, 2025
leigaol
reviewed
Sep 9, 2025
| const inlineChatTutorialAnnotation = new InlineChatTutorialAnnotation(inlineTutorialAnnotation) | ||
|
|
||
| const enableInlineRollback = true | ||
| const enableInlineRollback = FeatureConfigProvider.instance.getPreFlareRollbackGroup() === 'treatment' |
Contributor
There was a problem hiding this comment.
when this line of code is invoked at the activation phrase, the feature config API has not been called and it won't know if it is treatment or not.
Can you do this:
- In the FeatureConfig provider, when it call getPreFlareRollbackGroup. If there is API response, if this response is not the same as disk cache, override disk cache. If the response is the same as disk cache. do nothing. If this
getPreFlareRollbackGroupis called even before the listFeatureEvaluation API call, then just return from the cache.
Contributor
Author
There was a problem hiding this comment.
I setup debug mode and it was called before this line, let me double check again
Contributor
Author
There was a problem hiding this comment.
2025-09-08 18:51:01.940 [info] AB Testing Cohort Assignments [
{
feature: 'PreflareRollbackExperiment_BID',
variation: 'CONTROL',
value: { stringValue: 'CONTROL' }
}
]
2025-09-08 18:51:01.940 [debug] CodeWhisperer: Current feature configs: {PreflareRollbackExperiment_BID: CONTROL}
2025-09-08 18:51:03.182 [info] Command: (not started) [/Users/yuxqiang/Library/Caches/aws/toolkits/language-servers/AmazonQ/1.31.0/servers/node --inspect=6080 --max-old-space-size=8196 /Users/yuxqiang/Library/Caches/aws/toolkits/language-servers/AmazonQ/1.31.0/servers/aws-lsp-codewhisperer.js --nolazy --preserve-symlinks --stdio --pre-init-encryption --set-credentials-encryption-key] (running processes: 1)
2025-09-08 18:51:04.014 [debug] amazonqLsp: Fetching config section aws.q for language server
2025-09-08 18:51:04.014 [debug] amazonqLsp: Fetching config section aws.q for language server
2025-09-08 18:51:04.380 [debug] codewhisperer: new user login, activating inline tutorial. (autotriggerEnabled=true; inlineState=amazonq_annotation_inline_chat)
2025-09-08 18:51:04.380 [info] Entering postflare logic
Contributor
Author
There was a problem hiding this comment.
also:
// This contains every lsp agnostic things (auth, security scan, code scan)
await activateCodeWhisperer(extContext as ExtContext)
if (!isAmazonLinux2() || hasGlibcPatch()) {
// Activate Amazon Q LSP for everyone unless they're using AL2 without the glibc patch
await activateAmazonqLsp(context)
}
activateCodeWhisperer will call fetchFeatureConfig once at the end, activateAmazonqLsp will deterine whether it goes the preflare or post flare path.
leigaol
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.